tweak kontainer tests to reduce flake#17736
Open
mantis-toboggan-md wants to merge 4 commits into
Open
Conversation
| }); | ||
|
|
||
| // wait for driver to be active | ||
| driversPage.list().details(exampleDriver, 1).should('contain', 'Active'); |
Member
Author
There was a problem hiding this comment.
No check for Activating->Active status here because the driver may be updated to Active too quickly, introducing some flakiness
|
|
||
| driversPage.list().details(exampleDriver, 1).should('contain', 'Activating'); | ||
| driversPage.list().details(exampleDriver, 1).contains('Active', { timeout: 60000 }); | ||
| driversPage.list().details(exampleDriver, 1).should('contain', 'Active', LONG_TIMEOUT_OPT ); |
Member
There was a problem hiding this comment.
Question
I think the LONG_TIMEOUT_OPT cannot be used on the .should.
That is for most of the cases here. Are you sure it is actually applying the timeout?
I faced this problem before. (And I think I still have similar codes not working)
I usually change to something like this.
driversPage.list().details(exampleDriver, 1).contains('Active', LONG_TIMEOUT_OPT);
I am happy to discuss if you are not sure. I did some tests but we can check together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #17735
Occurred changes and/or fixed issues
This PR updates kontainer driver tests to remove a race condition. Instead of waiting for an Activating state in one driver before asserting an Activating state in another, which may have already progressed to Active, only the Active state is asserted in the bulk activation step.
The Activating -> Active status updates are still validated in the 'can create new driver' test
also in this pr:
Checklist
Admin,Standard UserandUser Base